Create a new translation class to address NF -> Nomad conversion

nextflow-io / nf-nomad

Hashicorp Nomad executor plugin for Nextflow

https://nextflow-io.github.io/nf-nomad/

Apache License 2.0

2 stars 2 forks source link

Create a new translation class to address NF -> Nomad conversion #29

Open abhi18av opened 3 months ago

abhi18av commented 3 months ago

@jagedn initially suggested a new TaskResource class addressing this translation layer.

I do think that we can explore the idea regarding a specific "translation" class which covers all aspects of NomadJobDefinition from a NextflowTask, however I suggest that we still continue the current iterations and revisit this once the plugin has stabilised in its design - what do you think?

_Originally posted by @abhi18av in https://github.com/nextflow-io/nf-nomad/pull/27#discussion_r1520634963_

jagedn commented 3 months ago

I like your implementation in NomadService using the TaskRun , in this way the complexity to build a NomadJob is hidden to NextflowTask so by the moment I think is a good approach