nextflow-io / nf-nomad

Hashicorp Nomad executor plugin for Nextflow
https://nextflow-io.github.io/nf-nomad/
Apache License 2.0
2 stars 4 forks source link

implementation of possibility to add multiple volumes #46

Closed jagedn closed 5 months ago

jagedn commented 5 months ago

This implementation introduces a new config volumes (plural) as a List of VolumeSpec closures

Tested against the validation folder:

 jobs {
        volume = { type "host" name "scratchdir" }

        volumes = [
            { type "host" name "scratchdir" path "/var/data1" },
            { type "host" name "scratchdir" path "/var/data2" }
        ]
    }

closes #45

jagedn commented 5 months ago

Looks good as far as I can understand the code :)

You can take a look to the examples in the validation folder, these are "real" configurations executed against a local nomad instance

https://github.com/nextflow-io/nf-nomad/pull/46/files#diff-ee3e4320a49d7523b0af681bbc50ede9992e4094046302a2682764cdf9b44624