Constraints refactor to introduce a specific models package

nextflow-io / nf-nomad

Hashicorp Nomad executor plugin for Nextflow

https://nextflow-io.github.io/nf-nomad/

Apache License 2.0

2 stars 4 forks source link

Constraints refactor to introduce a specific models package #68

Closed abhi18av closed 4 months ago

abhi18av commented 4 months ago

Hi @jagedn 👋

While testing the #66 PR, I realized that we are using the Spec names quite often within the main source code, however as per Groovy best practices, maybe we should reserve that name only for tests.

With that in mind, I have refactored your PR to introduce a nextflow.nomad.models to accommodate all the utility classes which we need to model the configuration layer for the plugin.

Please let me know what do you think about the new structure overall?

jagedn commented 4 months ago

ok, Spec is very used also in DSL terminology but you're right , better to use Spec for Spock Specification and avoid confusion

(so, do I need to cancel my PR and we continue into yours right?)

abhi18av commented 4 months ago

@jagedn , no you can just merge into your branch and then delete this :)

We'll continue working on your branch and merge it finally to master

jagedn commented 4 months ago

ahhh true, your PR is against my branch