search

nextflow-io / nf-nomad

Hashicorp Nomad executor plugin for Nextflow
https://nextflow-io.github.io/nf-nomad/
Apache License 2.0
2 stars 4 forks source link

fix version in MANIFEST #94

Open matthdsm opened 1 week ago

matthdsm commented 1 week ago

Perhaps also find a way to keep the version numbers in sync across the repo?

jagedn commented 1 week ago

if I'm not wrong the jsonPlugin gradle task update this manifest when building the zip

https://github.com/nextflow-io/nf-nomad/blob/0fd345fb79325114d29b0e0d2feb5556b5b8f21f/buildSrc/src/main/groovy/nextflow/gradle/plugins/JsonPluginTask.groovy#L58

matthdsm commented 1 week ago

There has to be an issue with it somewhere I think 🤔 I'm seeing the following in my nextflow logs

Nov-12 09:39:36.154 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins declared=[nf-nomad@0.3.0]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins default=[]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginsFacade - Plugins resolved requirement=[nf-nomad@0.3.0]
Nov-12 09:39:36.156 [main] DEBUG nextflow.plugin.PluginUpdater - Installing plugin nf-nomad version: 0.3.0
Nov-12 09:39:36.204 [main] INFO  org.pf4j.AbstractPluginManager - Plugin 'nf-nomad@0.1.2' resolved
Nov-12 09:39:36.204 [main] INFO  org.pf4j.AbstractPluginManager - Start plugin 'nf-nomad@0.1.2'
jagedn commented 1 week ago

Will take a look, meanwhile we can merge your PR

matthdsm commented 1 week ago

I just checked the zip from the latest release and I can confirm the version in the manifest is correct. Perhaps it's something on my end

abhi18av commented 1 week ago

Hi @matthdsm , marking this as draft till you give a go ahead for the update.

The version in particular file hasn't caused issues earlier so maybe there's some nextflow.config of env variable file which is pointing to the wrong version of the plugin 🤔

matthdsm commented 1 day ago

Hi,

I investigated a bit more, and the issue lies in the plugin somewhere. The version is defined in 2 locations: $NXF_ASSETS/plugins/nf-nomad-0.3.0/classes/META-INF/MANIFEST.MF and $NXF_ASSETS/plugins/nf-nomad-0.3.0/META-INF/MANIFEST.MF

The manifest in the classes dir is set to 0.1.2, whereas the other one is correct.