search

nextflow-io / nf-prov

Apache License 2.0
27 stars 12 forks source link

Add task script to legacy format #28

Closed stevekm closed 8 months ago

stevekm commented 8 months ago

fixes #24

bentsherman commented 8 months ago

I was thinking to wait to do this as part of #16 , but it's a simple change so might as well do it now.

Did you test the change and are you happy with the output?

stevekm commented 8 months ago

It looks OK so far

My only real gripe is that newlines in the Nextflow process script section show up as \n in the JSON, however I looked into it and it seems that JSON does not actually allow for real newlines in string fields, so I think its unavoidable.

if there's any other changes needed I expect we can just do a followup for that later.

thanks

bentsherman commented 8 months ago

indeed, that's what you have to do with JSON, but conversely, if you view the JSON through a tool or GUI rather than directly, the tool will put the newlines back in for you