Open asp8200 opened 1 year ago
Hi, can you show me what the schema looks like? I may have a vague idea but need to confirm it first. (Also I'm pretty swamped ATM so I probably won't solve it before the hackathon, sorry for that)
I understand, Nicolas. No worries. Solving this issue doesn't seem super urgent or critical to me. Martin showed me the problem for both sarek and hlatyping. (I suspect that it is a problem with the nf-core pipelines that use nf-validation.) I believe Martin was using unaltered versions of assets/schema_input.json
.
In addition, I believe that Martin was able to reproduce the err msg on our dev-HPC (with internet) by setting "$schema": ""
in assets/schema_input.json
. I'll try to get Martin to supply further details on this issue.
Hi,
Here is the history of our setup and tests:
As we now have a workaround that makes it possible to run the pipelines from Tower in our production environment, this is not a critical issue. But we are assuming the validation of the parameters are useful to the users, so it would be nice if the issue could be fixed at some point, so that we may reintroduce the params validation feature for our users. 🙂
Hi @martinfthomsen thanks for this full description, you confirmed my suspicions. The problem lies with the library we use for the JSON schema. I'll see if I can find a fix from their side.
Hi so we moved the JSON schema parsing to another library in the last update. Can you retry with version 2.0.0 (mind that this version contains breaking changes that need some updates to the JSON schema! See here)
Hi can you try this again using nf-schema
? :)
Any news on this? :)
Any news on this? :)
Hi @nvnieuwk 👋 I'm afraid not. I don't use nf-Tower, and @martinfthomsen is on leave.
Hi, no problem I'll leave this open for a bit longer then :)
At DNGC, we encountered the following problem when trying to run nf-core pipelines from nf-tower on a HPC with no internet:
(TO-DO: Get nf version number from Martin.)
When disabling
validateParameters()
(for instance, by settingparams.validate_params=true
) there is no problem.This issue might be related to https://github.com/nextflow-io/nf-schema/issues/19.
@maxulysse was informed about this issue.
This issue was uncovered during our work on https://support.seqera.io/support/tickets/3811