search

nextflow-io / nf-schema

Functionality for working with pipeline and sample sheet schema files in Nextflow pipelines
https://nextflow-io.github.io/nf-schema/
Apache License 2.0
12 stars 21 forks source link

Do not validate Azure or GCP storage paths #29

Closed adamrtalbot closed 6 months ago

adamrtalbot commented 7 months ago

Similar to AWS, Azure and GCP do not handle empty files and directories very well (because they aren't real!). This PR ignores them in the same manner as AWS S3 blob storage.

Should fix #16

nvnieuwk commented 7 months ago

Can you update the changelog in the meantime?

adamrtalbot commented 6 months ago

Can you update the changelog in the meantime?

Done now, want me to merge?

nvnieuwk commented 6 months ago

Yeah you can go ahead! I'll release the fix tomorrow :)

adamrtalbot commented 6 months ago

Anywhere good to write tests before I merge?

nvnieuwk commented 6 months ago

You can add tests here: https://github.com/nextflow-io/nf-schema/blob/master/plugins/nf-schema/src/test/nextflow/validation/ValidateParametersTest.groovy (just some simple test with those paths suffices for now, I will expand this later when implementing the full support)

adamrtalbot commented 6 months ago

See https://github.com/nextflow-io/nf-schema/pull/29/commits/426296588371209e879038a54dcc4db3f4c559fc for tests. Good to go now once tests have passed.