nextflow-io / nf-schema

Functionality for working with pipeline and sample sheet schema files in Nextflow pipelines
https://nextflow-io.github.io/nf-schema/
Apache License 2.0
12 stars 21 forks source link

Fix the uniqueEntries filtering #48

Closed stekaz closed 2 months ago

stekaz commented 3 months ago

The UniqueEntriesEvaluator does not seem to correctly detect non-unique combinations, at least in my testing. This fix ensures that the combination of values for the given keys is unique across all objects in the array.

nvnieuwk commented 2 months ago

Hi sorry for taking so long to address this PR. I'll check it out now. Can you also update the changelog with this change?

stekaz commented 2 months ago

No worries at all! I have updated the changelog to reflect the changes. Please let me know if there's anything else that needs adjustment, thanks!

nvnieuwk commented 2 months ago

Thank you! :partying_face: