nextgenhealthcare / connect

The swiss army knife of healthcare integration.
Other
868 stars 265 forks source link

[BUG] Cannot set some SMTP Sender properties #5987

Open is-simon opened 7 months ago

is-simon commented 7 months ago

Describe the bug Some properties of the SMTP Sender connector cannot be set through the administrator. I was going to open an issue to support adding both CC and BCC when using the SMTP sender but then noticed that the properties already existed in the SmtpDispatcherProperties and were used in the SmtpDispatcher. The problem is that those properties are not set anywhere in the SmtpSender class because there is no text fields to represent them. After some investigation, it seems that there is 3 properties used on server side that cannot be configured using the administrator:

Expected behavior We should be able to set those properties while configuring the SMTP Sender through the administrator.

pacmano1 commented 7 months ago

Probably not a bug, rather a feature request to extend the current functionality.

is-simon commented 7 months ago

@pacmano1 Well, I wasn't sure if I should create a feature request or a bug report, but since the properties already exists and are used by the SmtpDispatcher, it sound to me more like an unintended "half commit". I can't explain why they would introduce those properties without a way to set them up! The "fix" will only concern client classes, the properties are already serialized/deserialized in the XML configuration.