nextgenhealthcare / connect

The swiss army knife of healthcare integration.
Other
914 stars 275 forks source link

DestinationSetFilter-name is not consistent with the Generated Script #6173

Open Yostheboss opened 5 months ago

Yostheboss commented 5 months ago

Describe the bug When a Destination Set Filter is created on a channel, and multiple values are added with the Condition 'Not Equal', I see that the Name of the filter shows that it's an OR filter, but the generated script shows && in the scripts. That is not consistent with the name... When I change the condition from 'not equal' to 'equals', the generated script shows || so that's fine.

Expected behavior I should expect consitency between the name of the filter and the generated script. When it uses '&&' the name should describe it as an 'AND' filter. When the script generates || the name should describe an OR filter.

Actual behavior When I create a filter with multiple values, the name says 'OR', but the generated script is an AND filter. (only when "Does not equal" is selected)

Screenshots

filter generated_script

Environment (please complete the following information):

Additional context Add any other context about the problem here.

tonygermano commented 5 months ago

I think the wording is ok. That's typically how you would say it when spoken. Logically !(a || b || c) is equivalent to !a && !b && !c. If the wording were to be changed to use an "and" it should say does not equal 'abc' and does not equal 'def', which is pretty verbose, especially if there are more than two things to list.

If anything, I would change the wording to in list or not in list when there is more than 1 value being compared for "equals" or "not equals" and get rid of the logical expressions in the description altogether.