search

nextgenusfs / funannotate

Eukaryotic Genome Annotation Pipeline
http://funannotate.readthedocs.io
BSD 2-Clause "Simplified" License
320 stars 85 forks source link

funannotate-predict.py: final proteins not copied #20

Closed h0ha closed 8 years ago

h0ha commented 8 years ago

https://github.com/nextgenusfs/funannotate/blob/master/bin/funannotate-predict.py#L999

hi! is it ok? or just lost?

Thank You )

nextgenusfs commented 8 years ago

This is a relict from previous version where I was outputting proteins from the GAG tool, however, GAG sometimes has problems translating proteins in the reverse strand, thus I elected to just sort of remove it. It would be trivial to add back in a translated proteins and transcribed transcripts if that would be useful output?

h0ha commented 8 years ago

IC Thank You! it's up to You. No need in it if it has a strange behavior. Closing?

nextgenusfs commented 8 years ago

I just fixed this to output both proteins and transcripts, but not using GAG - just parsing the final GBK file. Will be part of new release.

h0ha commented 8 years ago

Thanks!

nextgenusfs commented 8 years ago

fixed: https://github.com/nextgenusfs/funannotate/commit/9d6722d2e8c4dadbdb91d7cf931e391a7c9a42fe