search

nextjournal / clerk

⚡️ Moldable Live Programming for Clojure
https://clerk.vision
ISC License
1.74k stars 76 forks source link

Page size option throws on string values #584

Closed zampino closed 7 months ago

zampino commented 7 months ago

Reproduces with

^{::clerk/page-size nil}
(def string "bang!")

I think this expression is legit, since we use it for other collections where it works as expected.

Throws:

Unhandled clojure.lang.ExceptionInfo
   n must be a number?
   {:n nil, :xs "318"}
               viewer.cljc: 1409  nextjournal.clerk.viewer$bounded_count_opts/invokeStatic
               viewer.cljc: 1407  nextjournal.clerk.viewer$bounded_count_opts/invoke
               viewer.cljc: 1494  nextjournal.clerk.viewer$get_elision/invokeStatic
               viewer.cljc: 1492  nextjournal.clerk.viewer$get_elision/invoke
               viewer.cljc: 1526  nextjournal.clerk.viewer$present_PLUS_paginate_string/invokeStatic
               viewer.cljc: 1524  nextjournal.clerk.viewer$present_PLUS_paginate_string/invoke
               viewer.cljc: 1574  nextjournal.clerk.viewer$present_STAR_/invokeStatic
               viewer.cljc: 1555  nextjournal.clerk.viewer$present_STAR_/invoke
               viewer.cljc: 1659  nextjournal.clerk.viewer$present/invokeStatic
               viewer.cljc: 1651  nextjournal.clerk.viewer$present/invoke