search

nextjournal / clerk

⚡️ Moldable Live Programming for Clojure
https://clerk.vision
ISC License
1.74k stars 76 forks source link

Fix rendering images in static apps #591

Closed zampino closed 7 months ago

zampino commented 7 months ago

Also fixes elisions (non clickable) in static apps.

Fixes #590.

zampino commented 7 months ago

As an alternative, if we don't like boolean params, we could use some of the keys in doc like :out-path here https://github.com/nextjournal/clerk/blob/67b480a470553e197fdf52225183aa7aac0bf03c/src/nextjournal/clerk/viewer.cljc#L515-L520

I'm not sure we can unify that with render/static-app?, since the client has extra keys from builder/write-static-app which are not available during notebook presentation and vice versa.