search

nextjournal / clojure-mode

Clojure/Script mode for CodeMirror 6
https://nextjournal.github.io/clojure-mode/
Eclipse Public License 2.0
158 stars 19 forks source link

Slurp forward shortcut conflicts with macos #11

Closed den1k closed 3 years ago

den1k commented 3 years ago

image image

Heliosmaster commented 3 years ago

@den1k the shortcut is pretty standard though, and Emacs does the same. I'm not sure we should change this.

den1k commented 3 years ago

It's your call. However, I'm not sure how valuable that parity is with emacs when the shortcut shifts you into another macos space and the only way around it is to either close all other spaces or open preferences and disable the default shortcut. That's a lot to ask of users to make a shortcut work. If you can overwrite the OS default, that would be great.

mk commented 3 years ago

We also have slurp/barf forward bound to Mod-Shift-k/j, see: https://github.com/nextjournal/clojure-mode/blob/3277e2a36d123a34a5613275cde93f0e5557e797/src/main/nextjournal/clojure_mode/keymap.cljs#L122-L139

I'm struggling to find other bindings that work. In maria.cloud it's also bound to Cmd-Shift-ArrowRight but that overrides standard selection behavior.

@den1k let me know if you think Mod-Shift-k/j works.

mk commented 3 years ago

@den1k I've added the alternate keybindings to https://nextjournal.github.io/clojure-mode/. Please reopen if you think we should still add more alternatives for this.

den1k commented 3 years ago

@mk Mod-Shift-k/j works!