search

nextml / NEXT

NEXT is a machine learning system that runs in the cloud and makes it easy to develop, evaluate, and apply active learning in the real-world. Ask better questions. Get better results. Faster. Automated.
http://nextml.org
Apache License 2.0
160 stars 53 forks source link

Update local directory to use new endpoint as in #154 #165

Open dconathan opened 7 years ago

dconathan commented 7 years ago

I assume we're going to update the local examples to keep in step with examples, using the new endpoint.

Or better yet... is it possible to just get rid of local and make a more flexible launch.py with a --local flag that doesn't do the verify_environ(), etc.?

I could see reasons to still keep separate folders (e.g. docker_up.sh is very different for ec2 vs local)... but the docker-compose are almost identical. Would be nice to consolidate where possible, so fewer places to update when we make changes like this...

Thoughts?

lalitkumarj commented 7 years ago

This sounds fine - I approve of two separate launch.py's. A quick question

It's probably best to keep the docker-compose's separate unless you have a very compelling re-organization.

On Tue, Jan 17, 2017 at 1:52 PM, dconathan notifications@github.com wrote:

I assume we're going to update the local examples https://github.com/nextml/NEXT/tree/master/local to keep in step with examples https://github.com/nextml/NEXT/tree/master/examples, using the new endpoint.

Or better yet... is it possible to just get rid of local and make a more flexible launch.py with a --local flag that doesn't do the verify_environ(), etc.?

I could see reasons to still keep separate folders (e.g. docker_up.sh is very different for ec2 vs local)... but the docker-compose are almost identical. Would be nice to consolidate where possible, so fewer places to update when we make changes like this...

Thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nextml/NEXT/issues/165, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWhGJ2iNetfjjDNhuj0Usbaqd1JxJKWks5rTQ3UgaJpZM4LmBlN .

dconathan commented 7 years ago

Okay let's keep separate for now.

I'd prefer to keep supporting the launch script. This gives users a starting point to write their own launch scripts if they want to do some fancy prelaunch preprocessing. Also makes it slightly easier to find out what's happening under the hood rather than an auto-magical launch gui.