Implement 'retiring' experiments

nextml / NEXT

NEXT is a machine learning system that runs in the cloud and makes it easy to develop, evaluate, and apply active learning in the real-world. Ask better questions. Get better results. Faster. Automated.

http://nextml.org

Apache License 2.0

160 stars 54 forks source link

Implement 'retiring' experiments #199

Closed erinzm closed 7 years ago

erinzm commented 7 years ago

[x] Add experiment retired DB flag setting to ResourceManager
[x] Add seperate 'Live' and 'Retired' tabs to /dashboard/experiment_list
[x] Add API endpoint to get and set retired state
[x] Add a way to retire/unretire experiments to the dashboard

This PR adds the following API endpoints:

POST /dashboard/experiment/<exp_uid>/retire, optionally taking the form-data parameter retired:bool (default: True)

It also implements several miscellaneous /dashboard/experiment_list enhancements:

Cleaned up page markup
Rewrote scripts for the dashboard to use idiomatic JS and make use of jQuery's functionality, since we already have it included on every page
Fixed responsiveness on the dashboard - the table now properly collapses and horizontal-scrolls

The interface

'Live' tab

'Retired' tab

Retiring experiments

video (webm)

dconathan commented 7 years ago

Question: is "retired" state just for organizing the experiment list or is the idea to actually disable the getQuery/processAnswer apis?

erinzm commented 7 years ago

@dconathan I believe it's intended to be just organizational; you can read the Gitter backlog for some background on what Kwame originally proposed.

erinzm commented 7 years ago

@lalitkumarj This PR wasn't ready to be merged; I still need to implement UI for retiring experiments

lalitkumarj commented 7 years ago

My bad, I reverted it. Just let me know.

On Thu, Jul 13, 2017 at 11:26 PM, Liam Marshall notifications@github.com wrote:

@lalitkumarj https://github.com/lalitkumarj This PR wasn't ready to be merged

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nextml/NEXT/pull/199#issuecomment-315259972, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWhGH8b18Kxvsj0SzoS59xXuMv55XwFks5sNt_OgaJpZM4OXlB6 .

stsievert commented 7 years ago

Just for organizing the experiment list. I do not want to disable any endpoints. We need to add a sentence explaining that.

On 13 Jul 2017, at 20:52, dconathan wrote:

Question: is "retired" state just for organizing the experiment list or is the idea to actually disable the getQuery/processAnswer apis?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/nextml/NEXT/pull/199#issuecomment-315247707

erinzm commented 7 years ago

Added a note to that effect: 2017-07-14-55

erinzm commented 7 years ago

looks like I have to open a new PR; whatever revert Lalit did didn't reopen this one.

erinzm commented 7 years ago

I have pushed my UI stuff to this branch; this PR just isn't displaying the commits for some reason.

stsievert commented 7 years ago

Here's some edits to the documentation for retiring:

Retire or unretire the selected experiments.

Note: The retirement state of an experiment only effects where the dashboard link appears; it does not affect the ability to access the dashboard or crowdsourcing interface.