search

nextml / NEXT

NEXT is a machine learning system that runs in the cloud and makes it easy to develop, evaluate, and apply active learning in the real-world. Ask better questions. Get better results. Faster. Automated.
http://nextml.org
Apache License 2.0
160 stars 54 forks source link

Give Butler.Collections and Butler.Memory the python dict-api #208

Closed dconathan closed 6 years ago

dconathan commented 7 years ago

Allows you to use dict-like api for Collections. e.g. butler.experiment["foo"] = "bar" instead of butler.experiment.set(key="foo", value="bar").

New tests in Tests app to test this.

I also refactored the Tests app a little more. It probably could be cleaned up a bunch more to do more unit test-y things but it's good for now.

dconathan commented 7 years ago

Note that this is purely syntatic sugar on top of old api... should be 100% backwards compatible.

lalitkumarj commented 7 years ago

It looks good to me. Liam - can you take a look over this to confirm?

erinzm commented 7 years ago

LGTM! I'd advise putting tests of the Collections stuff in test_collection.py, since that's where all the other tests for Collection are currently.

lalitkumarj commented 7 years ago

Have we gone and moved all the old apps to using this? I would want that done before putting it into a release.

erinzm commented 7 years ago

Not afaik. I'd ping Devin.

Liam

On Wed, Oct 25, 2017 at 1:25 PM, Lalit Jain notifications@github.com wrote:

Have we gone and moved all the old apps to using this? I would want that done before putting it into a release.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nextml/NEXT/pull/208#issuecomment-339424994, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa8SeFpt6QofgcGg7whmuQEtLpTYRmZks5sv30CgaJpZM4PSBEQ .

dconathan commented 7 years ago

Old apps were not updated. This was a backwards compatible change.