Entity: allow relationship defined only on one side

[hrach]

I was thinking about this and came to the opinion, this would be probably wont-fix. It could bring many unexpected behavior, which would be hardly debuggable. See:

class Post {}
/**
 * @property Post $post {m:1 PostsRepository}
 */
class Comment {}

$this->post = ...
$comment = new Comment();
$comment->post = $this->post;

$this->orm->posts->persistAndFlush($this->post);
// comment is not stored...
// no exception, no error....

Also, it makes sense mainly for 1:M relationship on the m side.

Opinions?

[JanTvrdik]

+1 for now won't fix + possible reconsideration in the future

[f3l1x]

I know it's a won't fix. But, any idea? I think it could be great.

[hrach]

Idea about what? But you are right, let's reopen it and move it to 1.2 :)

[f3l1x]

I like Nextras\Orm but I think this one is only ugly thing.. :smiley:

We/you should fix this thing. What problems do you think could came across?

[hrach]

I have already mentioned one few comments above.

[f3l1x]

/**
 * @property Comment[] {1:m Comment}
 */
class Post {}

class Comment {}

Is it the way you suggest? Remove required relation in Comment, but optional?

[hrach]

No, on the other side, as in the exaple above. The comment wrongly mention the "M" side, but it should be the otherwise.

[f3l1x]

And how IDE suggest you comments in Post? Through {virtual}?

[hrach]

@f3l1x in no way. This is not a good example of one sided relationship. This is typical usecase when it doesn't make sense.

[f3l1x]

I see. I guess you may have chance defined relation on both side but in case of 1:m not required. Does it make sense? Or do you have any other idea?

[hrach]

Sorry, I don't understand what do you mean.

[f3l1x]

I have updated my previous comment.

[vitkutny]

@hrach exception při použití one sided relací

Nextras\Orm\InvalidModifierDefinitionException Modifier {1:1} in Ytnuk\Menu\Entity::$title property has unknown arguments: oneSided.

opraveno úpravou MetadataParser.php:307

            } else {
                $targetProperty = NULL;
                unset($args['oneSided']);
            }

[hrach]

Fixed. Thanks! I should write some tests... :)