Closed mrceperka closed 1 week ago
@hrach can this if
statement be removed?
https://github.com/nextras/orm/blob/82d0cfc277828ad71cbe66c02fb9de0577a7d74c/src/Collection/DbalCollection.php#L311
Probably. Not fully sure now what was the reason for it. You may try it and see if any test "needs it".
Probably. Not fully sure now what was the reason for it. You may try it and see if any test "needs it".
I've found it :(
-- FAILED: integration/Collection/collection.phpt dataprovider=sqlsrv|/home/runner/work/orm/orm/tests/cases/integration/Collection/../../../databases.ini method=testCountStoredDbalWithoutOrderByClause
Exited with error code 255 (expected 0)
Nextras\Dbal\Drivers\Exception\QueryException: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near 'OFFSET'.
We could workaround it and keep the ordering only for MSSQL.
Describe the bug Calling
$collection->countStored()
should removeORDER BY
clauseTo Reproduce
Expected behavior
ORDER BY
clause should be removedVersions:
TODO