Replace dynamics namespaces with classes

[timspainNERSC]

(If possible!)

The functions defining the behaviour of the mEVP, MEB and BBM dynamics solvers are grouped using namespaces, rather than classes. Using classes would potentially permit the use of the nextSIM-DG Module system to swap dynamics types at run time.

@winzerle and @einola: Is there a reason why these functions are in namespaces, rather than classes?

[winzerle]

Hi everyone and happy New Year!

There is no reason at all for it. First it was just part of the Momentum class and then, this strange solution made the development for Piotr and me easier. But of course, it should be a class.

Thomas

• ---

  | Prof. Dr. Thomas Richter | Numerische Mathematik in den Anwendungen | Otto-von-Guericke Universität Magdeburg | numerics.ovgu.de | +49 391 67-57162 +49 176 615 612 26 (mobil)

On 2. Jan 2024, at 07:44, Tim Spain @.***> wrote:

(If possible!) The functions defining the behaviour of the mEVP, MEB and BBM dynamics solvers are grouped using namespaces, rather than classes. Using classes would potentially permit the use of the nextSIM-DG Module system to swap dynamics types at run time. @winzerle and @einola: Is there a reason why these functions are in namespaces, rather than classes? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[einola]

Hi, and Happy New Year!

I agree that there's no other reason than practical expediency during the development. We should, therefore, change it so it uses classes and the Module system.

[timspainNERSC]

The work for this is contained in PR #477

[timspainNERSC]

Fixed as part of PR #477.