search

nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Incorrect duration #473

Closed einola closed 8 months ago

einola commented 9 months ago

The thermodynamics test crashes with the message

libc++abi: terminating due to uncaught exception of type std::invalid_argument: The duration should be an ISO 8601 duration (P…) or a number of seconds. Got:

This seems to be related to PR #294, as rolling the model back to 55548256fa2f9bd1d4410e69c80f5d8be8865314 (before that PR) from 1eed3eee62025f190a4994286452245188e01e2d (current develop) the model runs fine.

The debugger was not very helpful, but I'm still investigating.

einola commented 9 months ago

I think there's something wrong with how string and istream are handled in Time.cpp. I am still figuring out exactly how to fix it.

timspainNERSC commented 9 months ago

The problem is with parsing an empty string, which is what the (absent) configuration defaults to.

timspainNERSC commented 8 months ago

Closing, since it is fixed.