nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Implement damage healing #529

Closed einola closed 2 months ago

einola commented 5 months ago

We still don't heal damage in BBM, which is needed for longer runs. There are two options for healing:

The temperature dependence in Olason et al. (2022) and Rampal et al. (2016) is very ad hoc but the best we have so far. It should be implemented in the thermodynamics routine. The problem is how to have healing independent of the chosen thermodynamics module - we don't want to re-implement the same thing repeatedly.

timspainNERSC commented 5 months ago

The way to avoid repeated re-implementation is to use the Module system.

The call tree from PrognosticData::update() into the thermodynamics is:

I would suggest that an additional call could be made to the new IDamageHealing::update() within IceGrowth::update(). Unless the damage healing has to be embedded inside ThermoWinton::update()/ThermoIce0::update() for a reason I am not currently seeing.

timspainNERSC commented 2 months ago

Fixed by merging PR #607 (Once again, I feel this should happen more automatically).

einola commented 2 months ago

I should have closed it manually, of course :/

It should close automatically because the PR commit message contains the magic string "Fixes #ISSUE-NUMBER". See https://github.com/gitbucket/gitbucket/wiki/How-to-Close-Reference-issues-and-pull-request

I'll open a separate issue.