nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG

https://nextsim-dg.readthedocs.io/en/latest/?badge=latest

Apache License 2.0

10 stars 13 forks source link

Dimension names #551

Closed timspainNERSC closed 6 months ago

timspainNERSC commented 6 months ago

Dimension names

Fixes #550

Change Description

For Cartesian restart files, both the dimensions of the fields and the coordinate positions share the names x and y. This is confusing to humans reading these files, but causes Panoply to refuse to plot the fields at all.

Rename the dimensions to x_dim and y_dim.

Test Description

The ParaGrid and RectGrid tests should still run

Documentation Impact

No impact: these names are held within the creation scripts.

timspainNERSC commented 6 months ago

Seems reasonable to me. The only place that it's particularly difficult to read is in the dimensionKeys definition, but these are private anyway.

I'm definitely open to a better way to handle that part :)