nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Dimension names redux #557

Closed timspainNERSC closed 6 months ago

timspainNERSC commented 6 months ago

Dimension names redux

Fixes #550 (again)


Change Description

Accept both the new (xdim, ydim, zdim) and old (x, y, z) dimension names to increase compatibility.


Test Description

Added a test that reads in a file with the old dimension names are ensures the dimensions are still set correctly.


Documentation Impact

No impact. This is a convenience detail and no users should be writing new restart files using the old dimension names.


Other Details

The generated old_names.nc file will suffer the same deficiencies as the restart files used to but will never be updated.