jwallwork23 commented 5 months ago

Use `size_t` for sizes in XIOS interface

Fixes #572

Fixes #562

Task List

[x] Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
[x] Implemented the source code change that satisfies the tests
[x] Documented the feature by providing worked example
[x] Updated the README or other documentation
[x] Completed the pre-Request checklist below

Change Description

Use size_t for sizes in the XIOS interface, rather than int, for consistency with the rest of the code base. Also, throw exceptions if the getter methods return null pointers.

NOTE: #559 and #574 will need to be merged first.

Test Description

Updated the tests accordingly.

Pre-Request Checklist

[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[x] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README

jwallwork23 commented 5 months ago

Ready for review, but #559 and #574 will need to be merged first so not assigning a reviewer yet.

jwallwork23 commented 5 months ago

Could you add some sort of prefix to the exception messages so that the user knows they came from within XIOS/Xios.cpp? (Assuming this isn't prepended by a higher level try/catch).

Thanks @timspainNERSC. How about this in cfc56a99?

timspainNERSC commented 5 months ago

Perfect!

jwallwork23 commented 5 months ago

Thanks! Will update file dates and then merge.

nextsimhub / nextsimdg