nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Tidy up TODOs from XIOS interface #581

Closed jwallwork23 closed 1 week ago

jwallwork23 commented 2 weeks ago

xios_c_interface.hpp contains three TODOs:

cxios_date cxios_date_convert_from_string(const char* str, int str_size); // TODO: unused
void cxios_calendar_wrapper_handle_create(
    xios::CCalendarWrapper** calendar_wrapper_hdl, const char* _id, int _id_len); // TODO: unused
void cxios_get_current_calendar_wrapper(xios::CCalendarWrapper** _ret); // TODO: unused

We can use the first to set the start/origin date directly from a string. The second one can be dropped as not needed. The third one is actually used so we can remove the TODO note.

jwallwork23 commented 1 week ago

Closed by #584.