nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Use `const` qualifiers in XIOS interface #585

Closed jwallwork23 closed 1 week ago

jwallwork23 commented 1 week ago

Use const qualifiers in XIOS interface

Fixes #583

Task List


Change Description

I realised the Xios class contained many methods where read-only arguments aren't given the const qualifier. This is rectified in this PR.


Test Description

Same goes for the XIOS tests.


Pre-Request Checklist

jwallwork23 commented 1 week ago

Looks good as far as it goes. But can any more of the member functions be declared const?

Thanks!

I don't think so? There are vectors that only get read in but I couldn't make them const because their data method gets called.