[ ] Implemented the source code change that satisfies the tests
[ ] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[ ] Completed the pre-Request checklist below
Change Description
So far we have only considered writing to file in the XIOS integration work. This PR will enable reading from file, too, although there seems to be a hitch with completing this right now.
XIOS' read methods are wrapped, as well as methods for setting file attributes related to the file mode (read vs. write) and parallel access mode.
Test Description
A XiosRead_test.cpp script is added, which reads from a input.nc file and checks its dimensions and values are as expected.
Question for reviewer: is it okay to add a NetCDF file to the repo? (I notice such files are ignored by default so had to force-add it.)
This PR also modifies XiosFile_test.cpp to test the newly wrapped parts of the XIOS API related to file attributes, as well as modifying XiosWrite_test.cpp to check the existence of output.nc and delete it at the end of the test.
Pre-Request Checklist
[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[ ] File dates have been updated to reflect modification date
[ ] This change conforms to the conventions described in the README
Wrap XIOS functionality for reading from file
Fixes #577
Task List
Change Description
So far we have only considered writing to file in the XIOS integration work. This PR will enable reading from file, too, although there seems to be a hitch with completing this right now.
XIOS' read methods are wrapped, as well as methods for setting file attributes related to the file mode (read vs. write) and parallel access mode.
Test Description
A
XiosRead_test.cppscript is added, which reads from ainput.ncfile and checks its dimensions and values are as expected.Question for reviewer: is it okay to add a NetCDF file to the repo? (I notice such files are ignored by default so had to force-add it.)
This PR also modifies
XiosFile_test.cppto test the newly wrapped parts of the XIOS API related to file attributes, as well as modifyingXiosWrite_test.cppto check the existence ofoutput.ncand delete it at the end of the test.Pre-Request Checklist