[x] Implemented the source code change that satisfies the tests
[ ] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[x] Completed the pre-Request checklist below
Change Description
This PR primarily fixes an issue where the model would crash when using BBM because the velocity averages used for advection were not initialised. I then discovered several smaller issues, the most important one being that damage was initialised to zero in the benchmark test case when it should be set to one.
Test Description
The benchmark test case now runs (using config_benchmark.cfg) and produces results qualitatively similar to those Piotr had in his previous tests.
Documentation Impact
N/A
Other Details
N/A
Pre-Request Checklist
[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[x] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README
Please complete your pull request description and delete the instructional text before submitting.
Congratulations and thank you for making your contribution to neXtSIM_DG!
Fixes to a few BBM issues
Fixes #578
Task List
Change Description
This PR primarily fixes an issue where the model would crash when using BBM because the velocity averages used for advection were not initialised. I then discovered several smaller issues, the most important one being that damage was initialised to zero in the benchmark test case when it should be set to one.
Test Description
The benchmark test case now runs (using
config_benchmark.cfg) and produces results qualitatively similar to those Piotr had in his previous tests.Documentation Impact
N/A
Other Details
N/A
Pre-Request Checklist
Please complete your pull request description and delete the instructional text before submitting.
Congratulations and thank you for making your contribution to neXtSIM_DG!