nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

ConfigOutput only generates output if ``start`` option is set #599

Closed einola closed 3 months ago

einola commented 3 months ago

The ConfigOutput module will not generate any output if the ConfigOutput.start option is not set. The expectation is that not setting ConfigOutput.start is equivalent to setting it to the model start (Model.start).

To reproduce, pick a favourite config file (e.g. config_column.cfg) and remove the ConfigOutput.start option.

timspainNERSC commented 3 months ago

The default value of the start time should be the model start time. I'm sure I wrote code to do this in the past. The help text even says that model.start is the default value. I'm not sure what happened to that code.

    map[pfx] = {
        …
        { startKey, ConfigType::STRING, {}, "model.start", "",
            "Date at which to start outputting data." },
        …
    };