nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Issue622 netcdfheaders #624

Closed timspainNERSC closed 4 months ago

timspainNERSC commented 4 months ago

Remove netCDF headers from headers

Fixes #622


Change Description

As a general rule, I have tried to isolate the netCDF headers at the lowest level possible, so that they do not leak out and end up being visible across the whole of nextSIM. The changes introduced by the addition of MPI violate this in ModelMetadata.hpp. By moving the headers to the .cpp file, order is restored.


Test Description

The model still compiles with MPI and the MPI tests still pass.