nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG
https://nextsim-dg.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
10 stars 13 forks source link

Make DG fields in the restart file self-consistent #654

Closed timspainNERSC closed 2 months ago

timspainNERSC commented 3 months ago

Currently, the thermodynamics runs after the dynamics. Since the thermodynamics changes the mean, DG0 value of prognostic fields, this can mean that the higher DG components could be such that the value of the field exceeds its physical limits. To be fully consistent the final state of fields with both DG components and geophysical limits should be immediately after the dynamics, when the limiters have just been applied.

The solution to this would be to swap the order of the dynamics and thermodynamics within the PrognosticData::update().