nextsimhub / nextsimdg

neXtSIM_DG : next generation sea-ice model with DG

https://nextsim-dg.readthedocs.io/en/latest/?badge=latest

Apache License 2.0

10 stars 13 forks source link

Automatically close linked issues (also in develop) #656

Closed einola closed 3 months ago

einola commented 3 months ago

Automatically close linked issues (also in develop)

Fixes #619

Task List

[x] Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
[x] Implemented the source code change that satisfies the tests
[x] Documented the feature by providing worked example
[x] Updated the README or other documentation
[x] Completed the pre-Request checklist below

Change Description

I updated the PR template to remove the "\" in "Fixes #(your issue number). This should mean that the issue closes automatically. Also fixed a bit the instructions for "Change Description".

Test Description

Can only be tested via a PR (this one!)

Documentation Impact

N/A

Other Details

N/A

Pre-Request Checklist

[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[x] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README

jwallwork23 commented 3 months ago

I'm surprised the Doxygen job runs because it is set to be triggered on a push to main, rather than a PR. I must've misunderstood something.

There are two sets of tests being run here: one from main and one from develop.

Given that Doxygen runs, the following snippet explains why there are two sets of tests: we have a "push" to main (in the sense above) and a PR open to be merged into develop.

on:
  push:
    branches: [ main, develop ]
  pull_request:
    branches: [ main, develop ]

What doesn't make sense to me is that it would run the old version of the tests from main as well as those from develop, rather than just running two sets of tests as in develop.