Add sea-surface height

Fixes #538

Task List

[x] Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
[x] Implemented the source code change that satisfies the tests
[ ] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[x] Completed the pre-Request checklist below

Change Description

This PR adds the contribution of the sea-surface-height gradient to both the mEVP and BBM codes (through VPCGDynamicsKernel and BrittleDynamicsKernel). SSH is read in from IOceanBoundary and passed to the dynamical core. It can also be output through ConfigOutput as "ssh".

Test Description

No unit test was implemented for this feature, and no quantitative test exists. Qualitative testing shows that setting a fixed sea-surface-height gradient gives drift speed close to back-of-the-envelope estimates (13 cm/s modelled, 20 cm/s from back-of-the-envelope).

Documentation Impact

None

Other Details

None

Pre-Request Checklist

[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[x] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README

It should be a variable like H and A, so HField appears good.

| Prof. Dr. Thomas Richter | Numerische Mathematik in den Anwendungen | Otto-von-Guericke Universität Magdeburg | numerics.ovgu.de | +49 391 67-57162 +49 176 615 612 26 (mobil)

On 1. Oct 2024, at 16:42, Tim Spain @.***> wrote:

@timspainNERSC requested changes on this pull request. Just one small change. I am assuming that the sea-surface gradient calculation code is correct.In physics/src/modules/include/IOceanBoundary.hpp:

@@ -86,6 +89,7 @@ class IOceanBoundary : public ModelComponent { HField cpml; // Heat capacity of the mixed layer, J K⁻¹ m² UField u; // x(east)-ward ocean current, m s⁻¹ VField v; // y(north)-ward ocean current, m s⁻¹

VField ssh; // sea surface height, m

This should be an HField, I believe. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

nextsimhub / nextsimdg

Issue538 seasurfaceheight #662