Closed Thanduriel closed 1 week ago
After our shenanigans with develop and having a working integration test, I'm afraid this branch needs rebasing.
This one was a little more tricky than a rebase. I'd appreciate if we could merge this in short order now, it is just a few lines after all.
memory leaks in dynamics
Fixes #716
Change Description
With #674 integrated, all dynamic buffers held by modules should get freed before the program terminates. This update replaces raw pointers with
std::unique_ptr
for heap buffers that are used internally by the dynamics.Test Description
A manual test was done by running the dynamics benchmark for 1 time step with valgrind:
The setup that was used is not suited for an automated test as it is takes too long (init + 1 step on 32x32 grid takes upwards of 30mins).