nextstrain / .github

8 stars 11 forks source link

Centralize existing pathogen build workflows #46

Closed joverlee521 closed 1 month ago

joverlee521 commented 11 months ago

Context

We now have a centralized reusable GitHub Action workflow for running pathogen builds.

We should update existing pathogen build workflows to use the centralized workflow to make future maintenance easier for ourselves and to discover any pitfalls in reusable workflow that may have been overlooked during development.

Hopefully there shouldn't be any huge changes that need to happen to the reusable workflow, but better to discover them now than later when it's widely used.

Description

Here's a list of repos that should be updated to use the new workflow:

Examples

See example use of the reusable workflow in seasonal-flu

genehack commented 1 month ago

@joverlee521 looks like the only unticked box in the original TODO list is for ncov, and I see a merged PR against ncov ...is this issue maybe done?

joverlee521 commented 1 month ago

@genehack The merged PR is for ncov-ingest which is a separate repo than ncov. The ncov GH Action workflows still need to be migrated.

genehack commented 1 month ago

The need to update the CI workflow in ncov has been moved to a new issue in the ncov repo.

Closing this issue out.

joverlee521 commented 1 month ago

@genehack, I completely misread your previous issue! This is actually regarding the use of the pathogen-repo-build workflow. I've made a new issue to track the separate task: https://github.com/nextstrain/ncov/issues/1113