Open jameshadfield opened 9 months ago
Brief notes running into this in a different context, our validation error code printed
.ancestral {"inference": "joint", "root_seq": false, "genom…} failed additionalProperties validation for false
Which isn't helpful. The first error.args
value was helpful (in this case):
Additional properties are not allowed ('genome_root_seq' was unexpected)
Note that in this case error.validator_value = False
which is where the "validation for false" phrasing comes from.
Validation against schemas is currently extremely useful at identifying when a dataset doesn't conform but often doesn't help pinpoint the part of the dataset that needs fixing.
As an example, this Auspice dataset ash_10samps.json (from https://github.com/nextstrain/auspice/issues/1756) failed validation in two places:
In instead we could change the error reporting to something like the following then debugging would be a whole lot easier, both for us internally and for external users: