search

nextstrain / augur

Pipeline components for real-time phylodynamic analysis
https://docs.nextstrain.org/projects/augur/
GNU Affero General Public License v3.0
268 stars 128 forks source link

Stop quoting TSV outputs from augur curate #1493

Closed joverlee521 closed 1 week ago

joverlee521 commented 1 week ago

Description of proposed changes

Resolves #1312 by never quoting output fields from write_records_to_tsv. See commits for details.

Checklist

joverlee521 commented 1 week ago

Rebased on to master to prevent merge conflicts in the changelog and added a changelog entry.

victorlin commented 6 days ago

@genehack how did you approve a merged PR?? I haven't seen that option so I use a ✅ comment instead...

joverlee521 commented 6 days ago

@genehack how did you approve a merged PR?? I haven't seen that option so I use a ✅ comment instead...

Huh, gh cli allows it: https://github.com/cli/cli/issues/5038

(I just tried it on https://github.com/nextstrain/augur/pull/1500)

genehack commented 6 days ago

@genehack how did you approve a merged PR?? I haven't seen that option so I use a ✅ comment instead...

I had it open in a tab from friday and didn't realize it had been merged when I approved it — the tab I was looking at said "OPEN" still!

victorlin commented 6 days ago

Huh, gh cli allows it: cli/cli#5038

Oh neat! Maybe I'll use that in the future... or just stick to the emoji if I'm lazy