Closed genehack closed 5 days ago
@joverlee521 I wonder if filter-strain-name
would be a better command name? This isn't really transforming anything, it's dropping things that don't match.
@joverlee521 I wonder if
filter-strain-name
would be a better command name? This isn't really transforming anything, it's dropping things that don't match.
Yeah, I was debating on this when I wrote up the issue. I think eventually the command would be expanded to transform strain names as described in https://github.com/nextstrain/augur/issues/1515.
Yeah, I was debating on this when I wrote up the issue. I think eventually the command would be expanded to transform strain names as described in #1515.
Yeah, okay, fair.
Attention: Patch coverage is 96.29630%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 69.63%. Comparing base (
c679fde
) to head (d33556c
).
Files | Patch % | Lines |
---|---|---|
augur/curate/transform_strain_name.py | 96.15% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of proposed changes
Port
ingest/transform-strain-names
toaugur curate transform-strain-name
, add tests.Related issue(s)
1486
https://github.com/nextstrain/ingest/issues/43
Checklist