Open joverlee521 opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.22%. Comparing base (
c28fab2
) to head (ad029f6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let's discuss this topic more first. I'll open an issue for it.
Saving this here for later…
Quote in field value in CSV input.
$ augur curate passthru --metadata <(echo 'a,b'; echo 'x,"y""z"') --output-metadata -
a b
x "y""z"
Quote in field value in NDJSON input.
$ augur curate passthru --output-metadata - <<<'{"a":"x","b":"y\"z"}'
a b
x "y""z"
Tab in field value in NDJSON input.
$ augur curate passthru --output-metadata - <<<'{"x":"\u0009"}'
x
" "
I think this PR should be ready for review based on https://github.com/nextstrain/augur/issues/1566#issuecomment-2356678703.
Description of proposed changes
Follow the general pattern of creating CSV-like TSVs as discussed in https://github.com/nextstrain/augur/pull/1563#discussion_r1699260164.
We are expecting the CSV-like double quoting when there are internal quotes. If the field value is already correctly double quoted, then there should not be any additional quotes.
Related issue(s)
Resolves https://github.com/nextstrain/augur/issues/1312
Checklist