nextstrain / augur

Pipeline components for real-time phylodynamic analysis
https://docs.nextstrain.org/projects/augur/
GNU Affero General Public License v3.0
268 stars 128 forks source link

index: Allow FileNotFoundError to be handled at the top level #1646

Closed victorlin closed 1 month ago

victorlin commented 2 months ago

Description of proposed changes

The removed error handling is flawed: it assumes that FileNotFoundError can only come from a missing input file (--sequences). The reality is that FileNotFoundError can also come from a missing output directory (--output). The top-level exception handler parses the filepath from the error directly, which is accurate.

Related issue(s)

Fixes #1644

Checklist

victorlin commented 2 months ago

Updated tests in force-push.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.17%. Comparing base (bf05db8) to head (296a6c6). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
augur/index.py 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1646 +/- ## ========================================== + Coverage 71.14% 71.17% +0.03% ========================================== Files 79 79 Lines 8273 8268 -5 Branches 2010 2010 ========================================== - Hits 5886 5885 -1 + Misses 2099 2095 -4 Partials 288 288 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.