nextstrain / augur

Pipeline components for real-time phylodynamic analysis
https://docs.nextstrain.org/projects/augur/
GNU Affero General Public License v3.0
268 stars 128 forks source link

update treetime #429

Closed rneher closed 4 years ago

rneher commented 4 years ago

I'll soon release TreeTime 0.7. Most changes are internal, but some might affect augur since augur at times reaches deep into the "internals" of TreeTime. I have been running augur without problem using TT 0.7 but it should be tested more broadly. Two changes in particular might change some of augur's behavior:

rneher commented 4 years ago

just ran a few tests. One test fails here: https://github.com/nextstrain/augur/blob/master/augur/traits.py#L75 This is no longer allowed since node.sequence is now a protected attribute that you can't set from the outside.

This could either be fixed by using the same construction as done here https://github.com/nextstrain/augur/blob/master/augur/traits.py#L75

or by replacing the entire logic by https://github.com/neherlab/treetime/blob/master/treetime/wrappers.py#L678

jameshadfield commented 4 years ago

Released with 6.3.0