search

nextstrain / auspice.us

http://auspice.us
13 stars 8 forks source link

Upgrade to Node.js 18 #61

Closed victorlin closed 7 months ago

victorlin commented 1 year ago

Description of proposed changes

Node.js 16 will reach EOL on 2023-09-11¹. Node.js 18 is the next LTS version, with projected EOL on 2025-04-30.

¹ https://github.com/nodejs/Release/blob/6a881a11363eb601f17b2d46e3f1664db5ce2a3b/README.md

Testing

jameshadfield commented 1 year ago

Review app looks good - thanks @victorlin. Can we merge this, or is there a reason it's a draft PR?

victorlin commented 1 year ago

This PR is ready for review, but the nextstrain.org counterpart (https://github.com/nextstrain/nextstrain.org/pull/698) is blocked.

Note that if this PR is merged while the other is not, this would require developers to use Node.js 18 for auspice.us and Node.js 16 for nextstrain.org. It's not a problem for me since I'm used to having one Conda environment per repo, but I want to make sure this doesn't complicate things for others.