search

nextstrain / auspice.us

http://auspice.us
13 stars 8 forks source link

Auspice has no problem reading a broken nwk tree #66

Open corneliusroemer opened 11 months ago

corneliusroemer commented 11 months ago

Current Behavior

Fascinatingly, Auspice has no issue reading a broken nwk tree with unmatching parentheses.

When viewing the raw nwk tree in Auspice it didn't complain. Only when I ran it through augur export did I get a complaint.

It's not so much a bug as I'm surprised that we're not even logging anything to the console.

Expected behavior

When I give a broken nwk, Auspice warns me.

How to reproduce

Steps to reproduce the current behavior:

  1. Open tree.nwk.txt in auspice.us
  2. Observe that there is nothing logged to console
joverlee521 commented 11 months ago

parseNewick is the custom function for parsing a Newick string to a Javascript object. Looks like it currently does not do any sort of validation of the Newick format.

jameshadfield commented 9 months ago

As of #73 this file will no longer parse because it has single quotes (acting as an apostrophe) in node names, but the underlying unbalanced parentheses bug isn't fixed.