nextstrain / auspice

Web app for visualizing pathogen evolution
https://docs.nextstrain.org/projects/auspice/
GNU Affero General Public License v3.0
292 stars 162 forks source link

Measurements panel improvements #1463

Open joverlee521 opened 2 years ago

joverlee521 commented 2 years ago

Context
Improvements for the Measurements panel added in https://github.com/nextstrain/auspice/pull/1452.

TODOs

Prioritized (ordered from highest to lowest priority)

Not prioritized

Completed

huddlej commented 2 years ago

Playing with the measurements panel more today, I had a few comments/thoughts to add to the list above.

  1. +1 for handling the long card titles. In the example community build, I can only get the tree and measurements to appear side-by-side when I close the control panel.

Control panel open: FE1B2B16-696F-4431-9ABF-C1A041135BA9

Control panel closed: 5EEC8CB8-01D6-4EC1-A79D-FCF6C7A07893

  1. In grid mode, there is no legend for measurement panel colors. It would be nice if the tooltip for grouped mean +/- SD mode also displayed the value associated with the color-by.
name of color-by value in tooltip would help understand plots
  1. What do colors mean in measurements panel when coloring the tree by a continuous attribute like number of epitope mutations? Related to the point above about tooltips, it would be helpful to include the group info in the tooltips for the mean +/- SD mode.

D2C4F6B1-4726-432F-AC44-474D5E308E9F

  1. In raw measurements display, it would be nice if the measurements could be grouped by color-by group like mean +/- SD, to minimize obscuring data points across groups. This would be aligned with how seaborn produces swarmplots with hues, as in this example from the original multiplot proposal issue:

Example swarmplot with grouped and jittered points

  1. Strains appear to have no value for log2 titer when plotted at log2 normalized titer of 0.0. Are the log2 values for these pairs actually 0.0 (and the issue is with the tooltip showing missing data) or are they missing (and the panel is somehow plotting them at 0.0 by default)?

5F589079-A1AD-4567-8DA5-FA221570645C

  1. Switching between collections resets the “Show overall mean +/- SD” and “Show measurements threshold” toggles and the “Group By” dropdown but does not reset the “Measurements display”. I was surprised to find that the overall mean toggle was not a setting for the whole panel instead of the collection being visualized. I'm not sure how we can communicate this subtle distinction in toggles in the UI though.
jameshadfield commented 2 years ago

What do colors mean in measurements panel when coloring the tree by a continuous attribute like number of epitope mutations?

Auspice groups continuous variables into a finite number of bins -- these are exposed in the legend, and hovering over each entry will highlight the matching tips. Bonus: this is user customisable. The measurements panel uses this same grouping. I agree that it would be nice to add this info to the on-hover tip box.

jameshadfield commented 2 years ago

Added to main list of TODOs


Some more improvements / experiments (via #1557)

joverlee521 commented 2 years ago

Added to main list of TODOs


Another improvement / experiment idea from @trvrb via Slack:

General feature I've wanted for the Measurements panel is to be able to click on a row at the y-axis (maybe with a little gear or spotlight following the name) that would then color the tree by this row's measurements.

huddlej commented 1 year ago

Added to main list of TODOs


From @rneher:

In the measurement panel, some limits on the axis might be useful as well. We currently have -6 to 14 in some views (which is a million fold titer difference):