search

nextstrain / auspice

Web app for visualizing pathogen evolution
https://docs.nextstrain.org/projects/auspice/
GNU Affero General Public License v3.0
292 stars 162 forks source link

Filtering being deactivated after clicking away from metadata popup #1701

Closed kvargha closed 7 months ago

kvargha commented 1 year ago

Current Behavior

When you click on a filtered sample and click away from the popup, the filter becomes deactivated.

Expected behavior

The filtered shouldn't be deactivated.

How to reproduce

Steps to reproduce the current behavior:

  1. Visit https://nextstrain.org/fetch/storage.googleapis.com/ucsc-gi-cdph-bigtree/CDPH_09_20_2023/CDPH-subtree-178.json?s=USA/CA-CDPH-2000016698/2021%7CEPI_ISL_2782613%7C2021-01-04,USA/CA-CDPH-2000016731/2021%7CEPI_ISL_2782386%7C2021-01-03
  2. Click "Zoom To Selected"
  3. Click on a sample
  4. Click away the popup.
  5. Samples filter should be deactivated.

Your environment: if browsing Nextstrain online

Additional context

Auspice Recording

sabbymama commented 9 months ago

I'm being ghosted by my sequences whenever I click on them. Will this be fixed soon?

joverlee521 commented 9 months ago

Noting this bug is part of the larger issue of the tip modal state not being accurately tracked in the redux state as described by @jameshadfield in https://github.com/nextstrain/auspice/issues/1243#issuecomment-977165516.

kvargha commented 8 months ago

Thank you for providing the background @joverlee521. Is there an estimate of when it will be fixed?

kvargha commented 7 months ago

@jameshadfield I'm still experiencing this issue.

victorlin commented 7 months ago

@kvargha the fix was merged and released in Auspice version 2.52.0, but nextstrain.org has not been updated yet. We may do that sometime this week. In the meantime, you can use https://next.nextstrain.org which is automatically updated with the latest version of Auspice.

kvargha commented 7 months ago

Gotcha. Thank you @victorlin.