search

nextstrain / auspice

Web app for visualizing pathogen evolution
https://docs.nextstrain.org/projects/auspice/
GNU Affero General Public License v3.0
292 stars 162 forks source link

Time to create a downstream PR preview is slower than desired #1709

Closed victorlin closed 3 months ago

victorlin commented 12 months ago

Context

When working on UI changes, it's useful to previews the changes on nextstrain.org. Currently, the process is simple but it takes a long time, at least 20 minutes: >10m to make the PR, then >10m to build the preview version of nextstrain.org. The slowness seems to be mostly due to npm install being slow when resolving git references.

Past discussions

This has been disussed in https://github.com/nextstrain/auspice/pull/1567#issuecomment-1273892375 and https://github.com/nextstrain/auspice/pull/1661#issuecomment-1500667474. I thought it would be fixed with the upgrade to Node.js 16, but looks like it's still taking a while.

Possible solutions

jameshadfield commented 3 months ago

Recent changes to how nextstrain.org is built & deployed have improved this a lot. npm is still slower installing from GitHub cf. the npm registry, but I don't think it's worth switching to yarn or similar. Please re-open this issue if it's still frustrating for anyone!