Migrate to modern Redux

victorlin commented 1 year ago

Redux was adopted in Auspice many years ago. Since then, Redux has developed new features to simplify usage (e.g. Redux Toolkit, hooks API).

Steps from the migration guide (doesn't have to be followed in order):

[x] Store Setup with configureStore: eb2c30f353483a8a544bf48cffe2677a6c7b3156
[ ] Reducers and Actions with createSlice
[ ] Data Fetching with RTK Query
[ ] Data Fetching with createAsyncThunk
[ ] Reactive Logic with createListenerMiddleware
[x] Migrating TypeScript for Redux Logic: 118ae19eaffb35390ef3106b4e8426de0846d546
[ ] Migrating connect to Hooks
- b8c65738ef9da277e70e29d016586af4b31e7132
[x] Migrating TypeScript for Components: 3e77a0a0f572db0e4621d9dfc3614a7353311be2

jameshadfield commented 1 year ago

Victor & I spoke about this briefly today. Having types flow through is really nice (e.g. #1710) however the work involved in moving from (non-trivial) class-components to hooks shouldn't be underestimated. Changing to createSlice looks to be a similar amount of work, and my intuition is that having a codebase using a mixture of createSlice and our current (and previously recommended) approach will be hard to reason with.

victorlin commented 3 weeks ago

I tried porting the tree reducers to createSlice briefly while working on #1864. Didn't get very far (69245533e6e0f342f4a0379730369b4ab4709afa), but my impression is that it's not easy or maybe even impossible to have a mixed codebase.

nextstrain / auspice

Migrate to modern Redux #1711