Revert to using CleanWebpackPlugin - Githubissues

nextstrain / auspice

Web app for visualizing pathogen evolution

https://docs.nextstrain.org/projects/auspice/

GNU Affero General Public License v3.0

292 stars 162 forks source link

Revert to using CleanWebpackPlugin #1738

Closed victorlin closed 8 months ago

victorlin commented 8 months ago

Description of proposed changes

This reverts "Replace CleanWebpackPlugin with output.clean" (798f3ee42) due to issues with Hot Module Replacement and output.clean.

Related issue(s)

Closes #1737

Checklist

[x] hot reloading works (can no longer repro #1737)
[x] Checks pass
[x] ~If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR~ no functional changes
[x] ~(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.~ not necessary

victorlin commented 8 months ago

A concentrated push sounds like the right approach here (instead of incremental pushes such as #1733). That would require much more effort and intention. I've added it to the "Project ideas" section in the priorities doc:

Modernize front-end codebases

TypeScript adoption in Auspice

Replace outdated usage of React, Webpack, Babel, Redux, etc.