Speed up review app installation

victorlin commented 1 month ago

Description of proposed changes

Reduce the time to create the preview PR from ~11m to ~3m.

[!NOTE] I plan to drop e4adf4f5f2d348b447d44bad64644fb5443d1ae3 since it doesn't seem to have any effect: compare runs before and after EDIT: keeping it as 2aba0cf9c320ca154484069435bb5ff7074ed2ee

Related issue(s)

1709

Checklist

[x] Checks pass
[x] ~If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR~
[x] (to be done by a Nextstrain team member) Create preview PRs on downstream repositories.

victorlin commented 1 month ago

@jameshadfield I forgot to explain in detail – I added that commit thinking it would ignore installation of Auspice devDependencies, but it only applies to devDependencies in the current project, i.e. nextstrain.org/auspice-client/package.json which has no devDependencies at the moment. You have a good point though – if that every changes in the future, we would still want to ignore devDependencies during installation for the review app. I'll keep the commit with a revised message.

Side note: the reason that Auspice devDependencies were installed and causing slowness was due to having a prepare script on a git install. NODE_ENV=production has no effect in this case. It is addressed with c90a465715232c16fe81d71e61509825ad07fd90 and https://github.com/nextstrain/nextstrain.org/commit/c3d38f25911dfadbbb9161d9e98f907181ab1d5e elsewhere.

victorlin commented 1 month ago

^ new preview PR is a bug. Will create a PR to fix.

nextstrain / auspice